jscheffl commented on code in PR #44326:
URL: https://github.com/apache/airflow/pull/44326#discussion_r1857390928
##########
Dockerfile.ci:
##########
@@ -1155,12 +1155,48 @@ function check_force_lowest_dependencies() {
set +x
}
+function check_airflow_python_client_installation() {
+ if [[ ${INSTALL_AIRFLOW_PYTHON_CLIENT=} != "true" ]]; then
+ return
+ fi
+ python "${IN_CONTAINER_DIR}/install_airflow_python_client.py"
+}
+
+function start_airflow_minimal_webserver_with_examples(){
+ if [[ ${START_AIRFLOW_MINIMAL_WEBSERVER_WITH_EXAMPLES=} != "true" ]]; then
+ return
+ fi
+ export AIRFLOW__CORE__LOAD_EXAMPLES=True
+ export
AIRFLOW__API__AUTH_BACKENDS=airflow.api.auth.backend.session,airflow.providers.fab.auth_manager.api.auth.backend.basic_auth
+ export AIRFLOW__WEBSERVER__EXPOSE_CONFIG=True
+ echo
+ echo "${COLOR_BLUE}Initializing database${COLOR_RESET}"
+ echo
+ airflow db migrate
+ echo
+ echo "${COLOR_BLUE}Database initialized${COLOR_RESET}"
+ echo
+ echo "${COLOR_BLUE}Parsing example dags${COLOR_RESET}"
+ echo
+ airflow scheduler --num-runs 100
Review Comment:
Why 100 runs? How did you get to this number?
##########
Dockerfile.ci:
##########
@@ -1155,12 +1155,48 @@ function check_force_lowest_dependencies() {
set +x
}
+function check_airflow_python_client_installation() {
+ if [[ ${INSTALL_AIRFLOW_PYTHON_CLIENT=} != "true" ]]; then
+ return
+ fi
+ python "${IN_CONTAINER_DIR}/install_airflow_python_client.py"
+}
+
+function start_airflow_minimal_webserver_with_examples(){
+ if [[ ${START_AIRFLOW_MINIMAL_WEBSERVER_WITH_EXAMPLES=} != "true" ]]; then
+ return
+ fi
+ export AIRFLOW__CORE__LOAD_EXAMPLES=True
+ export
AIRFLOW__API__AUTH_BACKENDS=airflow.api.auth.backend.session,airflow.providers.fab.auth_manager.api.auth.backend.basic_auth
+ export AIRFLOW__WEBSERVER__EXPOSE_CONFIG=True
+ echo
+ echo "${COLOR_BLUE}Initializing database${COLOR_RESET}"
+ echo
+ airflow db migrate
+ echo
+ echo "${COLOR_BLUE}Database initialized${COLOR_RESET}"
+ echo
+ echo "${COLOR_BLUE}Parsing example dags${COLOR_RESET}"
+ echo
+ airflow scheduler --num-runs 100
+ echo "Example dags parsing finished"
+ echo "Create admin user"
+ airflow users create -u admin -p admin -f Thor -l Administrator -r Admin
-e [email protected]
+ echo "Admin user created"
+ echo
+ echo "${COLOR_BLUE}Starting airflow webserver${COLOR_RESET}"
+ echo
+ airflow webserver --port 8080 --daemon && sleep 60
Review Comment:
Starting webserver and having a static sleep is a bit dangerous. Can you
check in comparison how it was made for internal API tests in
`scripts/docker/entrypoint_ci.sh:332` ? I think the start and poll for HTTP
port is more safe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
