potiuk commented on code in PR #44326:
URL: https://github.com/apache/airflow/pull/44326#discussion_r1859319733


##########
.github/workflows/ci.yml:
##########
@@ -505,6 +500,13 @@ jobs:
       upgrade-to-newer-dependencies: ${{ 
needs.build-info.outputs.upgrade-to-newer-dependencies }}
       include-success-outputs: ${{ 
needs.build-info.outputs.include-success-outputs }}
       debug-resources: ${{ needs.build-info.outputs.debug-resources }}
+      is-special-tests-require: ${{

Review Comment:
   Hmm. After a bit of thinking. one bad side-effect it has is that the whole 
"special tests" group will be evaluated and shown in the tree of tests for 
every PR - now for most PRs the whole group is skipped. 
   
   Maybe a better approach will be to move that one to "Static Checks, Mypy 
Docs" and rename it to something like "CI image checks"  (as the whole group?). 
The name is already too long:
   
   
![image](https://github.com/user-attachments/assets/7e23c35a-9c4e-42a8-81c1-cd50722f647f)
   
   
   There is a slightly different behaviour for "Special tests" - when special 
tests fail in "canary" build, the constraints are still updated, and probably 
there are cases where we want them not to be updated - if for examp[le a new 
version of a dependency will make the OpenAPI tests to fail.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to