ephraimbuddy commented on code in PR #44322:
URL: https://github.com/apache/airflow/pull/44322#discussion_r1858352825
##########
tests/api_fastapi/core_api/routes/public/test_connections.py:
##########
@@ -235,9 +235,7 @@ def test_post_should_respond_already_exist(self,
test_client, body):
# Another request
response = test_client.post("/public/connections/", json=body)
assert response.status_code == 409
- assert response.json() == {
- "detail": f"Connection with connection_id: `{TEST_CONN_ID}`
already exists",
- }
+ assert response.json() == {"detail": "Unique constraint violation"}
Review Comment:
> What type of error would you like to display @ephraimbuddy ?
The previous error message is more detailed than the generalized one. I
think we should continue with the current implementation that tells the user
what is wrong instead of a general one that would be confusing in some
endpoints. I don't have a strong opinion on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
