jason810496 commented on code in PR #44322:
URL: https://github.com/apache/airflow/pull/44322#discussion_r1860887450
##########
tests/api_fastapi/core_api/routes/public/test_connections.py:
##########
@@ -235,9 +235,7 @@ def test_post_should_respond_already_exist(self,
test_client, body):
# Another request
response = test_client.post("/public/connections/", json=body)
assert response.status_code == 409
- assert response.json() == {
- "detail": f"Connection with connection_id: `{TEST_CONN_ID}`
already exists",
- }
+ assert response.json() == {"detail": "Unique constraint violation"}
Review Comment:
In summary, this PR will only add `orig` and `statement` to the response
error details.
> Regexp can be not super reliable, also it will depends on the error
message of the database (which can change between releases and versions).
I will still explore the regex or string-matching approach in a follow-up PR.
FMO, database error messages do not change frequently ( also we won't
update the database driver version very often I think ). Even if the error
message changes after upgrading the database driver, fixing it in one global
handler would not be a significant issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
