kaxil commented on code in PR #44406:
URL: https://github.com/apache/airflow/pull/44406#discussion_r1859639051
##########
task_sdk/src/airflow/sdk/execution_time/supervisor.py:
##########
@@ -412,10 +414,6 @@ def _monitor_subprocess(self):
- Sends heartbeats to the client to keep the task alive
- Checks if the subprocess has exited
"""
- # Until we have a selector for the process, don't poll for more than
10s, just in case it exists but
- # doesn't produce any output
- max_poll_interval = 10
Review Comment:
I just replaced this too with `MIN_HEARTBEAT_INTERVAL`. I do need to add
`overtime` feature in the Supervisor -- will do in separate PR.
But let me know if you disagree with this @ashb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
