ashb commented on code in PR #44406:
URL: https://github.com/apache/airflow/pull/44406#discussion_r1860522257
##########
task_sdk/src/airflow/sdk/execution_time/supervisor.py:
##########
@@ -412,10 +414,6 @@ def _monitor_subprocess(self):
- Sends heartbeats to the client to keep the task alive
- Checks if the subprocess has exited
"""
- # Until we have a selector for the process, don't poll for more than
10s, just in case it exists but
- # doesn't produce any output
- max_poll_interval = 10
Review Comment:
This was previously to make sure that we call
`self._process.wait(timeout=0)` at most every 10s (since we spend most of our
time waiting on Readable events on the sockets.)
How ever that wasn't needed -- as the socket being closed, which happens
when the subprocess exits even if it produces no output, shows up as a readable
event (where upon reading gives the EOF) so that returns us from the select
already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
