ashb commented on code in PR #44449:
URL: https://github.com/apache/airflow/pull/44449#discussion_r1861871163
##########
airflow/api_fastapi/execution_api/routes/variables.py:
##########
@@ -67,6 +67,20 @@ def get_variable(variable_key: str, token: deps.TokenDep) ->
VariableResponse:
return VariableResponse(key=variable_key, value=variable_value)
[email protected](
+ "",
+ responses={
+ status.HTTP_401_UNAUTHORIZED: {"description": "Unauthorized"},
+ status.HTTP_403_FORBIDDEN: {"description": "Task does not have access
to the variable"},
+ },
+)
+def post_variable(body: VariablePostBody, token: deps.TokenDep) ->
VariableResponse:
+ """Set an Airflow Variable."""
+ # TODO: add the token validation
Review Comment:
Call `has_variable_access`, and add a new parameter to that function to make
it `has_variable_access(variable_key, token, write=True)` etc.
Though we should probably make better use of decorators/dependencies so we
don't need to handle this _inside_ each view function, but for now just follow
the pattern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
