ashb commented on code in PR #44449:
URL: https://github.com/apache/airflow/pull/44449#discussion_r1861922012
##########
airflow/api_fastapi/execution_api/routes/variables.py:
##########
@@ -67,6 +67,20 @@ def get_variable(variable_key: str, token: deps.TokenDep) ->
VariableResponse:
return VariableResponse(key=variable_key, value=variable_value)
[email protected](
+ "",
+ responses={
+ status.HTTP_401_UNAUTHORIZED: {"description": "Unauthorized"},
+ status.HTTP_403_FORBIDDEN: {"description": "Task does not have access
to the variable"},
+ },
+)
+def post_variable(body: VariablePostBody, token: deps.TokenDep) ->
VariableResponse:
Review Comment:
Design question: Should this be `POST /execution/variables` with key in the
body, or should it perhaps be `PUT /execution/variables/{variable_key}".
Possible advantage of the second approach: it shows in the request logs when
a specific variable is updated which might be nice.
Ultimately it doesn't really matter, and there is no "correct" way, it's
just up to us.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
