uranusjr commented on code in PR #43774:
URL: https://github.com/apache/airflow/pull/43774#discussion_r1863053388


##########
airflow/assets/manager.py:
##########
@@ -125,7 +125,9 @@ def register_asset_change(
         # todo: add test so that all usages of internal_api_call are added to 
rpc endpoint
         asset_model = session.scalar(
             select(AssetModel)
-            .where(AssetModel.uri == asset.uri)
+            .where(
+                AssetModel.name == asset.name, AssetModel.uri == asset.uri, 
AssetModel.group == asset.group

Review Comment:
   `group` is not in the unique key so selecting with it might cause some weird 
issues in edge cases. It _should not_ matter but…



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to