uranusjr commented on code in PR #43774:
URL: https://github.com/apache/airflow/pull/43774#discussion_r1863056304


##########
airflow/timetables/simple.py:
##########
@@ -170,7 +170,9 @@ def __init__(self, assets: BaseAsset) -> None:
         super().__init__()
         self.asset_condition = assets
         if isinstance(self.asset_condition, AssetAlias):
-            self.asset_condition = 
AssetAliasCondition(self.asset_condition.name)
+            self.asset_condition = AssetAliasCondition(
+                name=self.asset_condition.name, 
group=self.asset_condition.group
+            )

Review Comment:
   We should probably add some `as_xxx` functions on the classes so the logic 
is in one place (like `to_public`).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to