gopidesupavan commented on code in PR #44369:
URL: https://github.com/apache/airflow/pull/44369#discussion_r1863711969
##########
airflow/jobs/triggerer_job_runner.py:
##########
@@ -530,11 +530,9 @@ async def create_triggers(self):
while self.to_create:
trigger_id, trigger_instance = self.to_create.popleft()
if trigger_id not in self.triggers:
- ti: TaskInstance = trigger_instance.task_instance
self.triggers[trigger_id] = {
"task": asyncio.create_task(self.run_trigger(trigger_id,
trigger_instance)),
- "name":
f"{ti.dag_id}/{ti.run_id}/{ti.task_id}/{ti.map_index}/{ti.try_number} "
Review Comment:
I’m not entirely sure if it’s okay to remove the DAG information, but i
believe the trigger_id is essentially just an incremental value from the
database. The name parameter is used in multiple places within loggers, and I
feel it would be more useful if the name followed a recognizable pattern
instead of just being a number (trigger_id). This would also help users debug
issues more effectively by associating errors with the correct trigger and its
related DAG. WDYT?
eg:
https://github.com/apache/airflow/blob/main/airflow/jobs/triggerer_job_runner.py#L577
https://github.com/apache/airflow/blob/main/airflow/jobs/triggerer_job_runner.py#L583
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
