vincbeck commented on code in PR #44369:
URL: https://github.com/apache/airflow/pull/44369#discussion_r1863811962
##########
airflow/jobs/triggerer_job_runner.py:
##########
@@ -530,11 +530,9 @@ async def create_triggers(self):
while self.to_create:
trigger_id, trigger_instance = self.to_create.popleft()
if trigger_id not in self.triggers:
- ti: TaskInstance = trigger_instance.task_instance
self.triggers[trigger_id] = {
"task": asyncio.create_task(self.run_trigger(trigger_id,
trigger_instance)),
- "name":
f"{ti.dag_id}/{ti.run_id}/{ti.task_id}/{ti.map_index}/{ti.try_number} "
Review Comment:
Yes I was not sure either. To be honest I picked the trigger ID for
simplicity because I was not sure how much this `name` was used. But I agree,
we can do better here. I'll update it. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
