shahar1 commented on code in PR #43340:
URL: https://github.com/apache/airflow/pull/43340#discussion_r1864122640
##########
airflow/metrics/base_stats_logger.py:
##########
@@ -31,55 +33,53 @@ class StatsLogger(Protocol):
instance: StatsLogger | NoStatsLogger | None = None
- @classmethod
def incr(
cls,
- stat: str,
+ metric_name: str,
Review Comment:
@ferruzzi / @potiuk - should we consider it as a breaking change?
##########
airflow/metrics/base_stats_logger.py:
##########
@@ -31,55 +33,53 @@ class StatsLogger(Protocol):
instance: StatsLogger | NoStatsLogger | None = None
- @classmethod
Review Comment:
I'd be happy for an explanation about the removal of `@classmethod` - won't
it break the functionality that we have in `dag_processing/manager.py`? For
example:
https://github.com/apache/airflow/blob/1c0adb21f6cb5efa24270913444f189776835747/airflow/dag_processing/manager.py#L290C45-L290C46
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
