ferruzzi commented on code in PR #43340:
URL: https://github.com/apache/airflow/pull/43340#discussion_r1859144561
##########
tests/core/test_otel_logger.py:
##########
@@ -320,3 +333,43 @@ def test_timer_start_and_stop_manually_send_true(self,
mock_time, name):
self.meter.get_meter().create_observable_gauge.assert_called_once_with(
name=full_name(name), callbacks=ANY
)
+
+ def test_get_name_invalid_cases(self):
Review Comment:
Non-blocking nit-pick, feel free to ignore: All of these expected-to-fail
edge cases could be one parameterized test which parameterizes the name and the
expected error message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
