p13rr0m commented on PR #44564: URL: https://github.com/apache/airflow/pull/44564#issuecomment-2513384100
1. The CloudSQLExecuteQueryOperator is not yet offering the impersonation_chain parameter. https://github.com/apache/airflow/blob/a242ff6edb51db6e8ac1ced72b5bf327dd98c1b4/providers/src/airflow/providers/google/cloud/operators/cloud_sql.py#L1290 4. The download mechanism currently supports only CloudSQL Proxies with versions below 2. Updating this method and always downloading the latest version by default could introduce backward compatibility issues, such as conflicts with user-specified command line parameters. https://github.com/apache/airflow/blob/cc2f73c934526a13decee02db88a93561560b4fa/providers/src/airflow/providers/google/cloud/hooks/cloud_sql.py#L595 2. Ruff tells me there are some blank lines that contain whitespaces. 3. It looks like there a some merge commits in the PR. I believe Airflow recommends to use rebase commits. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
