jasonmar310 commented on PR #44564: URL: https://github.com/apache/airflow/pull/44564#issuecomment-2513424079
Hi @p13rr0m! Thanks for the detailed review. You've raised some great points that need addressing: 1. You're right - I'll add the `impersonation_chain` parameter to the CloudSQLExecuteQueryOperator. 2. Good catch on the proxy version handling - I'll update it to maintain backward compatibility by default while properly supporting v2. For 3,4 I'll clean up and rebase the commits to follow Airflow's guidelines. I'll push these updates shortly. Thanks for helping me improve this implementation! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
