eladkal commented on code in PR #44567:
URL: https://github.com/apache/airflow/pull/44567#discussion_r1867620511
##########
providers/src/airflow/providers/apache/spark/operators/spark_sql.py:
##########
@@ -94,15 +91,6 @@ def __init__(
self._yarn_queue = yarn_queue
self._hook: SparkSqlHook | None = None
- @property
- @deprecated(
- reason="`_sql` is deprecated and will be removed in the future. Please
use `sql` instead.",
- category=AirflowProviderDeprecationWarning,
- )
- def _sql(self):
- """Alias for ``sql``, used for compatibility (deprecated)."""
- return self.sql
Review Comment:
That is a bit odd?
private functions don't require deprecation. I assume this was a workaround
to deprecate `sql` not `_sql`
can you investigate? (git blame to find the previous PRs might help to see
what was the intention)
##########
providers/src/airflow/providers/apache/spark/operators/spark_sql.py:
##########
@@ -94,15 +91,6 @@ def __init__(
self._yarn_queue = yarn_queue
self._hook: SparkSqlHook | None = None
- @property
- @deprecated(
- reason="`_sql` is deprecated and will be removed in the future. Please
use `sql` instead.",
- category=AirflowProviderDeprecationWarning,
- )
- def _sql(self):
- """Alias for ``sql``, used for compatibility (deprecated)."""
- return self.sql
Review Comment:
That is a bit odd?
private functions don't require deprecation.
can you investigate? (git blame to find the previous PRs might help to see
what was the intention)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
