eladkal commented on code in PR #44567:
URL: https://github.com/apache/airflow/pull/44567#discussion_r1867655185
##########
providers/src/airflow/providers/apache/spark/operators/spark_sql.py:
##########
@@ -94,15 +91,6 @@ def __init__(
self._yarn_queue = yarn_queue
self._hook: SparkSqlHook | None = None
- @property
- @deprecated(
- reason="`_sql` is deprecated and will be removed in the future. Please
use `sql` instead.",
- category=AirflowProviderDeprecationWarning,
- )
- def _sql(self):
- """Alias for ``sql``, used for compatibility (deprecated)."""
- return self.sql
Review Comment:
Ah OK.. a piece of history :D
Lets add some clarification in the change log message that `_sql` was
introduced in 2016 and since it was listed in as templated field we handled it
as public api despite the `_` prefix that marked it as private.
(This is just so it wouldn't look odd why we create a breaking change
version to remove private parameter)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
