amoghrajesh commented on code in PR #44562:
URL: https://github.com/apache/airflow/pull/44562#discussion_r1868835153
##########
task_sdk/src/airflow/sdk/api/client.py:
##########
@@ -157,6 +158,12 @@ def get(self, key: str) -> VariableResponse:
resp = self.client.get(f"variables/{key}")
return VariableResponse.model_validate_json(resp.read())
+ def set(self, msg: PutVariable):
+ """Set an Airflow Variable via the API server."""
+ key = msg.key
+ self.client.put(f"variables/{key}", content=msg.model_dump_json())
Review Comment:
```
key = msg.key
body = VariablePostBody(**msg.model_dump(exclude_unset=True))
self.client.put(f"variables/{key}", content=body)
```
This seems cleaner than most of the other solutions I can think of, or we
can just pass them as individual parameters which is messier, instead its
better to pass them in an encapsulated manner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
