amoghrajesh commented on code in PR #44562:
URL: https://github.com/apache/airflow/pull/44562#discussion_r1868832541
##########
task_sdk/src/airflow/sdk/api/client.py:
##########
@@ -157,6 +158,12 @@ def get(self, key: str) -> VariableResponse:
resp = self.client.get(f"variables/{key}")
return VariableResponse.model_validate_json(resp.read())
+ def set(self, msg: PutVariable):
+ """Set an Airflow Variable via the API server."""
+ key = msg.key
+ self.client.put(f"variables/{key}", content=msg.model_dump_json())
Review Comment:
I tested it before implementing this part in this way. As per pydantic, the
extra fields by default are just blatantly ignored. Check here:
https://docs.pydantic.dev/latest/concepts/models/#extra-fields
Example:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
