tirkarthi commented on code in PR #44597:
URL: https://github.com/apache/airflow/pull/44597#discussion_r1869799856
##########
airflow/ui/src/pages/DagsList/Dag/Header.tsx:
##########
@@ -59,7 +63,15 @@ export const Header = ({
/>
)}
</HStack>
- <Flex>{dag ? <TriggerDAGTextButton dag={dag} /> : undefined}</Flex>
+ <Flex>
+ {dag ? (
+ <HStack>
+ <DagDocumentationButton setIsDocsOpen={setIsDocsOpen} />
Review Comment:
1. Agree on not showing the button when `doc_md` is empty
2. Is it possible to have `Dialog` outside the `tabs.tsx` ? I tried having
it as a component and remember facing is not showing up in expected way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
