bbovenzi commented on code in PR #44597:
URL: https://github.com/apache/airflow/pull/44597#discussion_r1869790390
##########
airflow/ui/src/pages/DagsList/Dag/Header.tsx:
##########
@@ -59,7 +63,15 @@ export const Header = ({
/>
)}
</HStack>
- <Flex>{dag ? <TriggerDAGTextButton dag={dag} /> : undefined}</Flex>
+ <Flex>
+ {dag ? (
+ <HStack>
+ <DagDocumentationButton setIsDocsOpen={setIsDocsOpen} />
Review Comment:
1. We should only show the docs button if there are docs
2. I think we can move the dag docs button and modal into a single component
that manages its own state. Then we have fewer imports and props to pass around.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
