pierrejeambrun commented on code in PR #44619:
URL: https://github.com/apache/airflow/pull/44619#discussion_r1871467204
##########
tests/api_fastapi/core_api/routes/public/test_connections.py:
##########
@@ -522,8 +522,8 @@ def test_patch_should_respond_200(self, test_client, body,
session):
"conn_type": TEST_CONN_TYPE,
"extra": None,
"host": TEST_CONN_HOST,
- "login": None,
- "port": None,
+ "login": TEST_CONN_LOGIN,
+ "port": TEST_CONN_PORT,
Review Comment:
Actually it's not. I will pass the serializer and then crash on the db side
trying to insert non nullable values. 🤔
Does this yield a 500 internal server error ? (whith original none, or
are they just ignored ?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
