ajitg25 commented on code in PR #44619:
URL: https://github.com/apache/airflow/pull/44619#discussion_r1871786284
##########
tests/api_fastapi/core_api/routes/public/test_connections.py:
##########
@@ -522,8 +522,8 @@ def test_patch_should_respond_200(self, test_client, body,
session):
"conn_type": TEST_CONN_TYPE,
"extra": None,
"host": TEST_CONN_HOST,
- "login": None,
- "port": None,
+ "login": TEST_CONN_LOGIN,
+ "port": TEST_CONN_PORT,
Review Comment:
We have `login` and `port` in the `update_mask`, but neither of them is
included in the request body. As a result, when we intersect `fields_to_update`
with `update_mask`, there will be no common fields. Consequently, nothing will
be updated, and the value will remain unchanged instead of being set to `None`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
