Re: [PR] AIP-84 Standardize patch behavior across endpoints in fast api [airflow]

Thu, 05 Dec 2024 10:03:17 -0800 


ajitg25 commented on code in PR #44619:
URL: https://github.com/apache/airflow/pull/44619#discussion_r1871797780


##########
tests/api_fastapi/core_api/routes/public/test_connections.py:
##########
@@ -522,8 +522,8 @@ def test_patch_should_respond_200(self, test_client, body, 
session):
                     "conn_type": TEST_CONN_TYPE,
                     "extra": None,
                     "host": TEST_CONN_HOST,
-                    "login": None,
-                    "port": None,
+                    "login": TEST_CONN_LOGIN,
+                    "port": TEST_CONN_PORT,

Review Comment:
   It dont give 500 error, its just assert failed
   ![WhatsApp Image 2024-12-05 at 22 54 
13](https://github.com/user-attachments/assets/a5b34620-5a26-4398-9e1d-ccb7745908f2)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to