dstandish commented on code in PR #44712: URL: https://github.com/apache/airflow/pull/44712#discussion_r1874068558
########## airflow/models/deadline.py: ########## @@ -0,0 +1,90 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +from datetime import datetime +from typing import TYPE_CHECKING + +import sqlalchemy_jsonfield +from sqlalchemy import Column, DateTime, Index, Integer, String + +from airflow.models.base import Base, StringID +from airflow.settings import json +from airflow.utils.log.logging_mixin import LoggingMixin +from airflow.utils.session import NEW_SESSION, provide_session + +if TYPE_CHECKING: + from sqlalchemy.orm import Session + + +class Deadline(Base, LoggingMixin): + """A Deadline is a 'need-by' date which triggers a callback if the provided time has passed.""" + + __tablename__ = "deadline" + + id = Column(Integer, primary_key=True, autoincrement=True) + + # If the Deadline Alert is for a DAG, store the DAG ID and Run ID from the dag_run. + dag_id = Column(StringID()) Review Comment: so if you use the PK then you only need to filter on one column vs two so by including PK, your life is made easier you can do ``` select start_date from dag_run dr where dr.id = deadline.dag_run_id ``` instead of ``` select start_date from dag_run dr where dr.dag_id = deadline.dag_id and dr.run_id = deadline.run_id ``` there is also a concept of relationships in sqlalchemy which basically means you don't have to write a query.... _sometimes_... but they're not always my favorite. you can do find in files and look for instances of `= relationship` for examples of what i'm talking about -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
