ferruzzi commented on code in PR #44712: URL: https://github.com/apache/airflow/pull/44712#discussion_r1874100497
########## airflow/models/deadline.py: ########## @@ -0,0 +1,90 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +from datetime import datetime +from typing import TYPE_CHECKING + +import sqlalchemy_jsonfield +from sqlalchemy import Column, DateTime, Index, Integer, String + +from airflow.models.base import Base, StringID +from airflow.settings import json +from airflow.utils.log.logging_mixin import LoggingMixin +from airflow.utils.session import NEW_SESSION, provide_session + +if TYPE_CHECKING: + from sqlalchemy.orm import Session + + +class Deadline(Base, LoggingMixin): + """A Deadline is a 'need-by' date which triggers a callback if the provided time has passed.""" + + __tablename__ = "deadline" + + id = Column(Integer, primary_key=True, autoincrement=True) + + # If the Deadline Alert is for a DAG, store the DAG ID and Run ID from the dag_run. + dag_id = Column(StringID()) Review Comment: AHA. Alright, I think maybe I misunderstood you and Vincent as suggesting that I drop both of those columns and replace them both with just the FK for dagrun.id So what you are actually saying is that run_id (the string like `manual__2024-12-06T22:07:22.834174+00:00`) isn't really useful by itself since it is not a unique value and multiple dags could conceivably have the same run_id; and that purpose is better served by dag_run.id (the integer PK) since that is a single-value lookup. So I'll still have `deadline.dag_id` and a column with a run identifier, but use `dagrun.id` for that identifier instead of `dagrun.run_id`. Did I follow that right? I'll look into the relationships too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
