potiuk commented on code in PR #44552:
URL: https://github.com/apache/airflow/pull/44552#discussion_r1874984635
##########
airflow/serialization/serialized_objects.py:
##########
@@ -784,7 +724,7 @@ def default_serialization(cls, strict, var) -> str:
return str(var)
@classmethod
- def deserialize(cls, encoded_var: Any, use_pydantic_models=False) -> Any:
+ def deserialize(cls, encoded_var: Any) -> Any:
Review Comment:
Yes. That's why I think **some** TODOs will stay after this one as we are
currently using Context Pydantic version to pass to PythonOperator - this one
will have to be replaced with whatever Context serialization TaskSDK has (cc:
@ashb @kaxil -> I have not looked at this yet, but since we are using HTTPs to
send the context to SDK and Pydantic classes for Task SDK under-the hood, so I
guess we will be able to re-use what's there.
For now I think I will just have to copy privately the Pydantic classes
needed to the Python Operator, to make it possible to use standard operator,
but we will eventually have to do it "better" - lilkely after this PR is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
