uranusjr commented on code in PR #44778:
URL: https://github.com/apache/airflow/pull/44778#discussion_r1875606195
##########
airflow/migrations/versions/0039_3_0_0_tweak_assetaliasmodel_to_match_asset.py:
##########
@@ -59,7 +59,7 @@ def upgrade():
"""Tweak AssetAliasModel to match AssetModel."""
with op.batch_alter_table("dataset_alias", schema=None) as batch_op:
batch_op.alter_column("name", type_=_STRING_COLUMN_TYPE,
nullable=False)
- batch_op.add_column(sa.Column("group", _STRING_COLUMN_TYPE,
default=str, nullable=False))
+ batch_op.add_column(sa.Column("group", _STRING_COLUMN_TYPE,
default="asset", nullable=False))
Review Comment:
I decided to do the same for assets. Also I realised the current way we set
defaults would not work because `default` is client-side. I fixed this with a
three-step (add-fill-constrain) approach for both tables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
