Lee-W commented on code in PR #44778:
URL: https://github.com/apache/airflow/pull/44778#discussion_r1875673513
##########
task_sdk/src/airflow/sdk/definitions/asset/__init__.py:
##########
@@ -391,10 +391,10 @@ class Model(Asset):
@attrs.define(unsafe_hash=False)
class AssetAlias(BaseAsset):
- """A represeation of asset alias which is used to create asset during the
runtime."""
+ """A representation of asset alias which is used to create asset during
the runtime."""
name: str = attrs.field(validator=_validate_non_empty_identifier)
- group: str = attrs.field(kw_only=True, default="",
validator=_validate_identifier)
+ group: str = attrs.field(kw_only=True, default="asset",
validator=_validate_identifier)
Review Comment:
Not sure whether it should be `asset` or `asset-alis`. Either way I'm ok.
just want to point it out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
