jedcunningham commented on code in PR #44755:
URL: https://github.com/apache/airflow/pull/44755#discussion_r1876794686


##########
tests/sensors/test_base.py:
##########
@@ -1022,31 +1008,20 @@ def test_sensor_with_xcom_fails(self, make_sensor):
         assert actual_xcom_value is None
 
     @pytest.mark.parametrize(
-        "executor_cls_mode",
+        "executor_cls, expected_mode",

Review Comment:
   So, I decided to move away from the "test everything in the Airflow 
ecosystem" approach, since this test is really about making sure 
`change_sensor_mode_to_reschedule` is honored.
   
   And we don't even get here with this refactor, the CE import up top is where 
this blew up.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to