potiuk commented on code in PR #44755:
URL: https://github.com/apache/airflow/pull/44755#discussion_r1875620951
##########
tests/executors/test_executor_loader.py:
##########
@@ -146,6 +146,11 @@ def test_get_hybrid_executors_from_config(self,
executor_config, expected_execut
assert executors == expected_executors_list
def test_init_executors(self):
+ # We need to init provider config in order to import CeleryExecutor
+ ProvidersManager().initialize_providers_configuration()
+
+ from airflow.providers.celery.executors.celery_executor import
CeleryExecutor
+
Review Comment:
See :
https://github.com/apache/airflow/blob/main/contributing-docs/07_local_virtualenv.rst#creating-virtualenvs-with-uv
-> explains both `uv` and `pip` setup for the env.
I guess we should have two variants of the tests and skip one of them
depending if the venv has the providers installed or not, or (maybe better)
split that tests and only check for presence of built-in providers, and have
similar tests in each of the providers - only checking for the presence of the
executor coming from the provider.
In the future when #44511 and when we (likely) separate executors in their
own packages, that might be handy (as we will have many more sub-projects - one
per each provider).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
