potiuk commented on code in PR #44802:
URL: https://github.com/apache/airflow/pull/44802#discussion_r1877480923
##########
dev/breeze/src/airflow_breeze/commands/testing_commands.py:
##########
@@ -1119,7 +1119,12 @@ def python_api_client_tests(
def run_with_timeout(timeout: int):
def timeout_handler(signum, frame):
get_console().print("[error]Timeout reached. Killing the process[/]")
- sys.exit(1)
+ run_command(
+ ["docker", "kill", "$(docker ps -q)"],
Review Comment:
Did you actually check it works (say run test with 20 seconds timeout)?
I am afraid that will not relaly work - unless it is donw with `shell=True`
and making it single string.
The `${docker ps -q)` is not a regular argument, it should be expanded by
shell and the way it is used now it will passed as argument.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
