bugraoz93 commented on code in PR #44802:
URL: https://github.com/apache/airflow/pull/44802#discussion_r1877915729
##########
dev/breeze/src/airflow_breeze/commands/testing_commands.py:
##########
@@ -1119,7 +1119,12 @@ def python_api_client_tests(
def run_with_timeout(timeout: int):
def timeout_handler(signum, frame):
get_console().print("[error]Timeout reached. Killing the process[/]")
- sys.exit(1)
+ run_command(
+ ["docker", "kill", "$(docker ps -q)"],
Review Comment:
I'm sorry, I needed to go offline early yesterday and couldn't properly test
it! I wanted to collect early feedback to see if any other part should be
considered. This was indeed to the point feedback I was seeking :)
Now, I have tested locally and adjusted the code accordingly. It exposes
all container logs to the console before exiting the actual process. I tested
with `sys.exit()` too to ensure it is working as expected, I haven't seen the
logs in this case exit at the timeout
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
