pierrejeambrun commented on code in PR #44516:
URL: https://github.com/apache/airflow/pull/44516#discussion_r1878471399


##########
airflow/api_fastapi/common/parameters.py:
##########
@@ -146,6 +147,127 @@ def depends_search(value: str | None = 
Query(alias=pattern_name, default=None))
     return depends_search
 
 
+class SearchPatternEnum(Enum):

Review Comment:
   Maybe we should reuse `FilterOptionEnum` and rename it to a more `generic`  
name. Maybe move it to the DB package with something like `ORMOperatorEnum` or 
something else.
   
   DB operations supported by the query parameters and the one from advanced 
search will basically be very close. (and this will avoid duplication). 
   
   As we do for `states` `task_states` `dag_run_states`, etc.. we can split 
`FilterOperator` `AdvancedSearchOperator`, etc...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to