pierrejeambrun commented on code in PR #44516:
URL: https://github.com/apache/airflow/pull/44516#discussion_r1884090471
##########
airflow/api_fastapi/common/parameters.py:
##########
@@ -146,6 +147,127 @@ def depends_search(value: str | None =
Query(alias=pattern_name, default=None))
return depends_search
+class SearchPatternEnum(Enum):
Review Comment:
I think the enumeration of all ORM operation could live in the db module of
FastAPI.
Then other enums FilterOperator, AdvancedSearchOperator can use that, but
basically Filter and Search are just query params, the difference is the db
operator that is used `airflow/utils/states.py` combines enums as well, could
be interesting to take a look.
That's not of big importance at this stage I think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
