potiuk commented on PR #44913: URL: https://github.com/apache/airflow/pull/44913#issuecomment-2541586255
Nice .. I like the idea. Tried to do similar thing to `common.sql` with stubgen (after initial attempt of doing it similarly to you) - but this explicit approach is I think better - even if requires more code. One other option I saw in Android OS (and maybe that is a good idea for you to explore) - was to turn the signatures into a plain-text file where you keep signatures of public methods - and keep it in the repository in the code. Then you do not have to check-out the previous version of the code (Which is not always available - in CI we only retrieve single commit and we do not have parent commit by default) - you just generate a new version of such signature "dump" file - then pre-commit framework will automatically see that the dump has changed and will fail precommit (and you would have to commit such modifed file to accept changed signatures) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
