mobuchowski commented on PR #44913: URL: https://github.com/apache/airflow/pull/44913#issuecomment-2543970859
>One other option I saw in Android OS (and maybe that is a good idea for you to explore) - was to turn the signatures into a plain-text file where you keep signatures of public methods - and keep it in the repository next to the code. Then you do not have to check-out the previous version of the code (Which is not always available - in CI we only retrieve single commit and we do not have parent commit by default) - you just generate a new version of such signature "dump" file - then pre-commit framework will automatically see that the dump has changed and will fail precommit (and you would have to commit such modifed file to accept changed signatures) @potiuk I think the advantage of this idea is that it allows you to _break_ the compatibility way easier - for example, if the old version of Airflow goes out of scope and providers can move to regular import from core Airflow. However, the two main issues remain: handling of imports - maybe mark them as API too somehow? This would allow us only to track relevant ones. Those nested classes - still not sure how to handle those. And I think if we're introducing this type of hook completeness is rather important, because when it passes, it suggests that all is good - while we can still have issues here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
