johnhoran commented on code in PR #44357:
URL: https://github.com/apache/airflow/pull/44357#discussion_r1885705803
##########
providers/src/airflow/providers/cncf/kubernetes/callbacks.py:
##########
@@ -50,7 +54,27 @@ def on_sync_client_creation(*, client: k8s.CoreV1Api,
**kwargs) -> None:
pass
@staticmethod
- def on_pod_creation(*, pod: k8s.V1Pod, client: client_type, mode: str,
**kwargs) -> None:
+ def on_manifest_finalization(
Review Comment:
Yep, sounds good to me. If you have a suggestion for the `on_pod_wrapup`
too, I struggled with that one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
