johnhoran commented on code in PR #44357:
URL: https://github.com/apache/airflow/pull/44357#discussion_r1885714136
##########
providers/src/airflow/providers/cncf/kubernetes/utils/pod_manager.py:
##########
@@ -446,8 +446,8 @@ def consume_logs(*, since_time: DateTime | None = None) ->
tuple[DateTime | None
progress_callback_lines.append(line)
else: # previous log line is complete
for line in progress_callback_lines:
- if self._callbacks:
- self._callbacks.progress_callback(
+ for callback in self._callbacks:
+ callback.progress_callback(
line=line, client=self._client,
mode=ExecutionMode.SYNC
Review Comment:
Callbacks aren't really implemented for async operation at the moment
unfortunately.
https://github.com/apache/airflow/pull/35714#issuecomment-1901447474.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
