jedcunningham commented on code in PR #44924:
URL: https://github.com/apache/airflow/pull/44924#discussion_r1887507690
##########
airflow/models/dag.py:
##########
@@ -2028,7 +2027,7 @@ class DagModel(Base):
fileloc = Column(String(2000))
# The base directory used by Dag Processor that parsed this dag.
processor_subdir = Column(String(2000), nullable=True)
- bundle_id = Column(UUIDType(binary=False), ForeignKey("dag_bundle.id"),
nullable=True)
+ bundle_name = Column(StringID(), ForeignKey("dag_bundle.name"),
nullable=True)
Review Comment:
The association table would have to also have a 'time' component - just
knowing it was, at one point, associated with another bundle isn't that
interesting. I kinda view the bundle similarly to the "fileloc" - the DAG
itself is the primary thing, the rest is just supplemental. The `enabled`
column on bundles today is enough to avoid cascading deletes.
I do think having complete history of the `dag` table could be useful, but I
don't want to take that on with these changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
