dstandish commented on code in PR #44924:
URL: https://github.com/apache/airflow/pull/44924#discussion_r1888992749
##########
airflow/models/dagbundle.py:
##########
@@ -16,58 +16,28 @@
# under the License.
from __future__ import annotations
-from typing import TYPE_CHECKING
-
-import uuid6
-from sqlalchemy import Column, Integer, String
-from sqlalchemy_utils import UUIDType
+from sqlalchemy import Boolean, Column, String
from airflow.models.base import Base, StringID
-from airflow.utils.module_loading import import_string
-from airflow.utils.session import NEW_SESSION, provide_session
-from airflow.utils.sqlalchemy import ExtendedJSON, UtcDateTime
-
-if TYPE_CHECKING:
- from sqlalchemy.orm import Session
-
- from airflow.dag_processing.bundles.base import BaseDagBundle
+from airflow.utils.sqlalchemy import UtcDateTime
class DagBundleModel(Base):
- """A table for DAG Bundle config."""
+ """
+ A table for storing DAG bundle metadata.
+
+ We track the following information about each bundle, as it can be useful
for
+ informational purposes and for debugging:
+ - enabled: Is the bundle currently found in configuration?
+ - latest_version: The latest version Airflow has seen for the bundle.
+ - last_refreshed: When the bundle was last refreshed.
+ """
__tablename__ = "dag_bundle"
- id = Column(UUIDType(binary=False), primary_key=True, default=uuid6.uuid7)
- name = Column(StringID(), nullable=False, unique=True)
- classpath = Column(String(1000), nullable=False)
- kwargs = Column(ExtendedJSON, nullable=True)
- refresh_interval = Column(Integer, nullable=True)
+ name = Column(StringID(), primary_key=True)
+ enabled = Column(Boolean, default=True)
Review Comment:
`active` is probably a better name since it's not something a user could
enable or disable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
