amoghrajesh opened a new pull request, #44977:
URL: https://github.com/apache/airflow/pull/44977
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
related: https://github.com/apache/airflow/issues/44414
This is an addition to https://github.com/apache/airflow/pull/44954 and is
dependent on it.
Only last commit is relevant cb493eee920229ac0358282f12d354d96121e1bf
We do not have to handle the case of external task state updates as well as
AFexception specifically in task_runner because public UI APIs will directly do
that job - core APIs. So there is no scenario when one of these exceptions are
thrown due to this:
https://github.com/apache/airflow/blob/83da311e4ce5a7965b2e1c412941a8f26ad8225e/task_sdk/src/airflow/sdk/execution_time/supervisor.py#L608-L615
We check with the database for the state with the heartbeat and if ever
there is a different state, other than running:
https://github.com/apache/airflow/blob/83da311e4ce5a7965b2e1c412941a8f26ad8225e/airflow/api_fastapi/execution_api/routes/task_instances.py#L210-L218,
we fail with a 409.
But, if this state is ever hit, we should just mark the TI as failed. There
are UTs
https://github.com/apache/airflow/compare/main...astronomer:airflow:AIP72-taskterminated-or-afexception?expand=1#diff-413c3c59636a3c7b41b8bb822827d18a959778d0b6331532e0db175c829dbfd2R342-R397
which handle this portion to check if it fails or not.
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
