amoghrajesh commented on code in PR #44977:
URL: https://github.com/apache/airflow/pull/44977#discussion_r1888045578
##########
task_sdk/src/airflow/sdk/execution_time/task_runner.py:
##########
@@ -283,9 +283,28 @@ def run(ti: RuntimeTaskInstance, log: Logger):
...
except (AirflowFailException, AirflowSensorTimeout):
# If AirflowFailException is raised, task should not retry.
+ # If a sensor in reschedule mode reaches timeout, task should not
retry.
+
+ # TODO: Handle fail_stop here:
https://github.com/apache/airflow/issues/44951
+ # TODO: Handle addition to Log table:
https://github.com/apache/airflow/issues/44952
+ msg = TaskState(
+ state=TerminalTIState.FAILED,
+ end_date=datetime.now(tz=timezone.utc),
+ )
+
+ # TODO: Run task failure callbacks here
+ except AirflowTaskTimeout:
+ # TODO: handle the case of up_for_retry here
...
- except (AirflowTaskTimeout, AirflowException, AirflowTaskTerminated):
- ...
+ except (AirflowException, AirflowTaskTerminated):
Review Comment:
Handled in aebe0aacadac15fce939acf08211fea60877efa3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
