jedcunningham commented on code in PR #45009:
URL: https://github.com/apache/airflow/pull/45009#discussion_r1893084947
##########
airflow/auth/managers/simple/simple_auth_manager.py:
##########
@@ -80,6 +81,9 @@ class
SimpleAuthManager(BaseAuthManager[SimpleAuthManagerUser]):
# Cache containing the password associated to a username
passwords: dict[str, str] = {}
+ # TODO: Needs to be deleted when Airflow 2 legacy UI is gone
+ appbuilder: AirflowAppBuilder | None = None
Review Comment:
> Today we do not have mechanism to add views to Airflow 3. I was counting
on AIP-68 but it seems it is kind of blocked.
I mean, that's what this PR is doing :)
I'm okay if we keep it short term so we can do changes in stages, but before
we actually release AF3 I think it should go. Simple auth manager will already
have to refactor this stuff - there will be no `AirflowBaseView` in core.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
