vincbeck commented on code in PR #45009:
URL: https://github.com/apache/airflow/pull/45009#discussion_r1893104863
##########
providers/src/airflow/providers/amazon/aws/auth_manager/aws_auth_manager.py:
##########
@@ -76,12 +76,12 @@ class AwsAuthManager(BaseAuthManager):
Leverages AWS services such as Amazon Identity Center and Amazon Verified
Permissions to perform
authentication and authorization in Airflow.
-
- :param appbuilder: the flask app builder
"""
- def __init__(self, appbuilder: AirflowAppBuilder) -> None:
- super().__init__(appbuilder)
+ appbuilder: AirflowAppBuilder | None = None
+
+ def __init__(self) -> None:
+ super().__init__()
Review Comment:
> Can we fix compatibility for the other stuff we've broken already?
We have not broken anything yet, this is the first PR. The 2 methods I
mention in the newsfragment are mandatory for AF3, not AF2. So the
compatibility is not broken this way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
