pierrejeambrun commented on code in PR #44332:
URL: https://github.com/apache/airflow/pull/44332#discussion_r1894583867
##########
airflow/api_fastapi/common/parameters.py:
##########
@@ -163,6 +164,19 @@ def __init__(
self.model = model
self.to_replace = to_replace
+ def __or__(self, other):
Review Comment:
I see why we do that.
The only thing is that If someone explicitly provide a filtering by
“primary_key” this will end up falling back on the other, while it is not what
the user want.
Maybe we can go around it by using 1 SortParam with all values authorised.
And put that custom logic in the transform_callback. Set the transform in the
body of the view. (param.transform = lambda dag: dag….).
And then use it.
Just an idea though.
i’ll do an in depth review this weekend but overall, it looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
