bugraoz93 commented on code in PR #44332:
URL: https://github.com/apache/airflow/pull/44332#discussion_r1894664798
##########
airflow/api_fastapi/common/parameters.py:
##########
@@ -163,6 +164,19 @@ def __init__(
self.model = model
self.to_replace = to_replace
+ def __or__(self, other):
Review Comment:
Yes, I am thinking the same when the primary key passes this will always
fall to `other`. Maybe we can have an alternative approach similar to Search
and Filter, creating the SortParam with the factory in this case. Do you mean
something similar to this? Or just defining the `depend` method with a
transform callback that the transform will be overridden in the view?
I am not sure if this is a needed feature for multiple use cases. This was
the only logical comparison I ended up with without expanding SortParam
initialisation. I am okay with both moving logic to view without expanding the
SortParam or expanding the SortParam to conform to the primary key case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
