amoghrajesh commented on code in PR #45143:
URL: https://github.com/apache/airflow/pull/45143#discussion_r1894823633
##########
scripts/ci/pre_commit/compile_ui_assets.py:
##########
@@ -68,10 +70,19 @@ def get_directory_hash(directory: Path, skip_path_regexp:
str | None = None) ->
shutil.rmtree(dist_directory, ignore_errors=True)
env = os.environ.copy()
env["FORCE_COLOR"] = "true"
- subprocess.check_call(
- ["pnpm", "install", "--frozen-lockfile",
"--config.confirmModulesPurge=false"],
- cwd=os.fspath(ui_directory),
- )
+ for try_num in range(3):
+ print(f"### Trying to install yarn dependencies: attempt: {try_num}
###")
Review Comment:
Nit: Let's move this entire block into a function? We can reuse that time.
And, we will be able to skip the try_number==2 check too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
