potiuk commented on code in PR #45143:
URL: https://github.com/apache/airflow/pull/45143#discussion_r1894824563
##########
scripts/ci/pre_commit/compile_ui_assets.py:
##########
@@ -68,10 +70,19 @@ def get_directory_hash(directory: Path, skip_path_regexp:
str | None = None) ->
shutil.rmtree(dist_directory, ignore_errors=True)
env = os.environ.copy()
env["FORCE_COLOR"] = "true"
- subprocess.check_call(
- ["pnpm", "install", "--frozen-lockfile",
"--config.confirmModulesPurge=false"],
- cwd=os.fspath(ui_directory),
- )
+ for try_num in range(3):
+ print(f"### Trying to install yarn dependencies: attempt: {try_num}
###")
Review Comment:
Not sure if I understand :) . .. These two are separate scripts - we
currently don't read anything from "common" scripts in them, that would be
somewhat increasing coupling between them. I think I prefere to not apply DRY
here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
